-
Notifications
You must be signed in to change notification settings - Fork 16
[Backport] Fix nil-pointer on accessing condition in autoscaler #634
Conversation
Hi @skonto. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Good point about the other places where the same access is used. I can't say for sure but it looks likely it will happen. |
/lgtm Still the checks need to pass before it will be merged. |
/lgtm The test is |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mgencur I am not sure If we want to go and fix every call but it seems that they are not protected as getting a specific condition may return a nil pointer. Same applies to other structures btw. Maybe the other calls never get a nil in any scenario. Let's see if this fixes the issue we see in our tests. |
@skonto right, I wouldn't be fixing the other occurrences either. That fix should probably go upstream first. We'll retest the current fix with soak tests with the new build and see if the issue is gone. I believe it will be. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@skonto: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Backport of knative#9794. I am wondering since there are direct calls to the struct fields elsewhere if we are going to hit this in other areas of the code base in the future. For example here.